docs: list all conformance commits #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Rexicon226
requested changes
Oct 1, 2025
Contributor
Rexicon226
left a comment
Rexicon226
left a comment
There was a problem hiding this comment.
Why not just have the circleci use these variables, instead of checking they exist inside of the config? This seems very roundabout to me.
Rexicon226
previously approved these changes
Oct 5, 2025
yewman
previously approved these changes
Oct 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Rexicon226
approved these changes
Oct 9, 2025
yewman
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
conformance/commits.envwith a commit hash of every repo used for testing sig's conformance with agave.It's important that these commits are the same commits that we're using in CI. Anyone should be able to easily check out our code and run conformance locally by using these commit hashes, with high confidence that everything will work and be conformant with the code we have on
main.For SOLANA_CONFORMANCE_COMMIT and TEST_VECTORS_COMMIT, I changed the CI to ensure these are always pulled in directly from commits.env and used to check out the actual code used in CI.
For the other commits, this is not possible since the artifacts are pre-generated and not checked out within CI. So I added a basic script to grep files for where these commit hashes are documented or used for other purposes, and set it up to run this verification script in CI. It isn't a foolproof check, but at least it will flag some inconsistencies. The first run detected an inconsistency that we have on main which I fixed in 1434e9d.